Use the exception log arg to log exception #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
commented
Jun 7, 2021
oxinabox
commented
Jun 7, 2021
src/citations.jl
Outdated
| @@ -12,8 +12,7 @@ function get_citation(pkg) | |||
| try | |||
| import_bibtex(bib_path) | |||
| catch e | |||
| @warn("There was an error reading the CITATION.bib file for $(pkg.name)") | |||
| @debug e | |||
| @warn("There was an error reading the CITATION.bib file for $(pkg.name)" exception=e) | |||
There was a problem hiding this comment.
Arguably this should bne
Suggested change
| @warn("There was an error reading the CITATION.bib file for $(pkg.name)" exception=e) | |
| @error "There was an error reading the CITATION.bib file for $(pkg.name)" exception=e |
This was an error, we were not even able to recover from it correctly.
we kept running cos we know it is safe, but the final output is wrong (because it is incomplete)
|
Thank you, I didn't know about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConsoleLogger (and probably others) have special handling for log arguments called
exception.(Can also pass backtrace there but that is probably too spammy).
using
@debugfor this just seems annoying. If there is an error I want to know what it is.Making me remember how to enable debug loading and then rerun is just annoying