Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on empty bib files #15

Merged
merged 8 commits into from
Aug 12, 2021
Merged

Fix error on empty bib files #15

merged 8 commits into from
Aug 12, 2021

Conversation

SebastianM-C
Copy link
Owner

Fix #13

@SebastianM-C SebastianM-C added the bug Something isn't working label Aug 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #15 (b06a43d) into master (e6bbf4e) will decrease coverage by 0.53%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   91.59%   91.05%   -0.54%     
==========================================
  Files           3        3              
  Lines         119      123       +4     
==========================================
+ Hits          109      112       +3     
- Misses         10       11       +1     
Impacted Files Coverage Δ
src/citations.jl 94.36% <80.00%> (-1.23%) ⬇️
src/tool_report.jl 85.71% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6bbf4e...b06a43d. Read the comment docs.

@SebastianM-C SebastianM-C merged commit 86f04ea into master Aug 12, 2021
@SebastianM-C SebastianM-C deleted the empty_bib branch August 12, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_tool_citations results in ERROR: ArgumentError: collection must be non-empty
2 participants