Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsc-nest-bug-fix-nestjs-connection #66

Merged
merged 1 commit into from
Dec 8, 2023
Merged

nsc-nest-bug-fix-nestjs-connection #66

merged 1 commit into from
Dec 8, 2023

Conversation

tinpham5614
Copy link
Contributor

Resolves: #63
This PR will fix the errors that cause NestJS can't run properly.

  1. Remove Inject AuthService
  2. Replace AuthService in AuthController

Results:

image

image

@tinpham5614 tinpham5614 added the bug Something isn't working label Dec 7, 2023
@tinpham5614 tinpham5614 self-assigned this Dec 7, 2023
@tinpham5614 tinpham5614 requested a review from a team as a code owner December 7, 2023 18:22
@tinpham5614 tinpham5614 requested review from bcko, Seiyaroo, brinkbrink, brandondombrowsky, taylorpapke and Robel-003 and removed request for a team December 7, 2023 18:22
@tinpham5614 tinpham5614 changed the title fix inject auth service error nsc-nest-bug-fix-nestjs-connection Dec 7, 2023
@tinpham5614 tinpham5614 mentioned this pull request Dec 7, 2023
Closed
@CourtneyHoppus
Copy link
Contributor

This is really strange how it differs from Belinda's. I went in a few circles setting that up, and from what I read, it has something to do with circular dependency with the injectables. That, along with creating aliases and using useClass vs useValue, I'm not sure I have a good grasp on how this is supposed to work optimally.
I tested that the tests passed and the app ran, both did.

CourtneyHoppus
CourtneyHoppus approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@CourtneyHoppus CourtneyHoppus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app is running and the tests are passing.
Did not test the functionality of the auth module.

taylorpapke
taylorpapke approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@taylorpapke taylorpapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass and Nest application successfully starts. Thanks!

@taylorpapke taylorpapke merged commit e6c42d2 into main Dec 8, 2023
@taylorpapke taylorpapke deleted the bug-63-fix-nestJS-connection-01 branch December 8, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CourtneyHoppus CourtneyHoppus CourtneyHoppus approved these changes

@taylorpapke taylorpapke taylorpapke approved these changes

@bcko bcko Awaiting requested review from bcko bcko was automatically assigned from SeattleColleges/leadership

@Seiyaroo Seiyaroo Awaiting requested review from Seiyaroo Seiyaroo was automatically assigned from SeattleColleges/leadership

@brinkbrink brinkbrink Awaiting requested review from brinkbrink brinkbrink was automatically assigned from SeattleColleges/leadership

@brandondombrowsky brandondombrowsky Awaiting requested review from brandondombrowsky brandondombrowsky was automatically assigned from SeattleColleges/leadership

@Robel-003 Robel-003 Awaiting requested review from Robel-003 Robel-003 was automatically assigned from SeattleColleges/leadership

Assignees

@tinpham5614 tinpham5614

Labels
bug Something isn't working
Projects
NSC Events
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Fix nestJS Connection
3 participants
@tinpham5614 @CourtneyHoppus @taylorpapke