nsc-events_3_39_update-user-dto-refactor

[CourtneyHoppus]

Resolves #39

I added a DTO for updating the user and refactored the controller and service to utilize this.
I removed the unused imports and the non-typed request parameters.
Removed redundant add User methods, the Auth module handles this.

When running npm install to be able to run the app with it's dependencies, it found a critical vulnerability:

---

I resolved this by running npm audit fix

Here is a document about connecting to a MongoDB Compass (local) instance. This is also the basic setup to connect to an Atlas (cloud) instance.

To test:

• pull branch
• run npm install
• run locally
• you must have a valid mongodb connection string and .env file set up
• run tests on user in Postman
• you must either
  • have a previously created user in your database and login through the /auth/login route
    OR:
  • create a new user using the /auth/signup route
• using the token sent back when logging in or creating a user as your bearer token to test:
  • get all users at /users route with GET call
  • get user by id at /users/find/:id route with GET call
  • get user by email at /users/email/:email route with GET call
  • update a user at /users/update/:id route with PATCH call
  • delete a user at /users/remove/:id route with DELETE call

[brinkbrink]

@CourtneyHoppus Some checks are failing here. I also auto-updated your branch. The checks were failing before the update, too, FYI. Click the "details" link next to the failed check for more details. Some of them can be automatically fixed but I didn't go through and do that in case you wanted to check them out.

[CourtneyHoppus]

Thanks @brinkbrink. When referring to the automatic fix, is there a linter we are using that I can run on my branch or is it the third-party CodeFactor that wants permission to access GitHub?
EDIT: I saw that CodeFactor was running Prettier and that there was a file for that in the project so I used Prettier to lint the files it was complaining about.

[Robel-003]

This looks great, nice job! All the api routes work as expected once I have signed up and signed in and used the provided token.
The update route returns helpful messages when updating a user. The delete api route doesn't seem to work though "/users/delete/:id", but this route works "/users/remove/:id"

Also, in the 4th bullet point under To test, I think it'd be helpful to add the connection link documentation Tin created.

[tinpham5614]

All endpoints are functional. It would be helpful to have a success message when removing a user.

[CourtneyHoppus]

@Robel-003 I added that link and updated the testing directions.
@brinkbrink I corrected the issues that were causing the checks to fail.
@tinpham5614 Happy to work on any additional back end issues that are found and created.

[Robel-003]

Looks great and it's working perfectly, thank you for making those changes! If you want to create issues for the comment Tin made, please feel free to do so. I'll go ahead and merge this into main