Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npc-events-nestjs_sprint14_issue#586_Minor-dependencies-update. #150

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

MiguelQuintana1
Copy link
Contributor

Resolves issue #586

this pull request will update Minor dependencies for this project, in my local environment everything runs very smoothly. all test passed.

Screenshot 2024-11-18 at 11 58 21 AM

Next will be the Major dependencies update:

Screenshot 2024-11-18 at 11 58 58 AM

this will update the Minor dependencies in this project.
Copy link
Contributor

@JesseCaddell JesseCaddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for making another PR. Looks like the Github Actions triggered and passed as we had hoped. Just a reminder that we need you to fill out the side bar when you make PRs and Issues. They shouldn't be left blank! This may be contributing to smartsheets integration hiccups we have had this last week. We are in the process of investigating.
image

Copy link

@JoyZhang2023 JoyZhang2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on my end. Good job! Thank you!

@IsaacJrTypes
Copy link
Contributor

Good work! I updated the PR by removing the carets in package.json file and handled the merge conflicts. To ensure that the updates did not affect the backend, I used Postman to test the api. Updates did not break the app, which is always a good thing.
CleanShot 2024-12-08 at 15 56 27

@IsaacJrTypes IsaacJrTypes merged commit f5cb456 into main Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants