-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nsc-events-nestjs-8-129-auto-archive-past-events #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working great. My events on the frontend that were expired were not on the Home page and the events that I edited to be before the current date and time were also archived. It seems one of the tests is now outdated because of your changes, you'll need to update the test before this is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great but might I suggest making it archive the event at the end of the day that it happens? That way the event can still be looked at on the current day it's scheduled for. I'm curious what other developers think.
@bennettsf I agree, that would be better. Or making the events archive as soon it hits the event's end time, perhaps? @Ali-7s Could we do this? |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Yeah, I just updated the code to implement it |
I'm late to the party but this looks great and functions as expected on my end when I create events with past due dates. Good job! |
@Ali-7s The events are no longer archiving with expired events or when I create events with past due dates or events that have started. ![]() |
Sorry about that, it should work now based on date and event end time Screen.Recording.2024-06-11.at.8.mp4 |
@Ali-7s It's working, but it seems I am only able to get an event to auto archive if the event is created using the Create Event page. Strangely, events created using Postman do not auto archive on my end. Did you create your events using the Create Event page or Postman? |
I created mine using the create event page |
Satisfies #129
Screen.Recording.2024-06-09.at.5.mp4