Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsc-events-nestjs-8-129-auto-archive-past-events #130

Merged
merged 9 commits into from
Jun 12, 2024

Conversation

Ali-7s
Copy link
Contributor

@Ali-7s Ali-7s commented Jun 10, 2024

Satisfies #129

  • Implements functionality to auto archive past events in the backend
Screen.Recording.2024-06-09.at.5.mp4

Copy link
Contributor

@heosman heosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working great. My events on the frontend that were expired were not on the Home page and the events that I edited to be before the current date and time were also archived. It seems one of the tests is now outdated because of your changes, you'll need to update the test before this is merged.

Copy link
Contributor

@JesseCaddell JesseCaddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well on my end! Made an event with a date that has passed, and it was auto added to the archived events page.
image

Copy link
Contributor

@bennettsf bennettsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great but might I suggest making it archive the event at the end of the day that it happens? That way the event can still be looked at on the current day it's scheduled for. I'm curious what other developers think.

@heosman
Copy link
Contributor

heosman commented Jun 10, 2024

@bennettsf I agree, that would be better. Or making the events archive as soon it hits the event's end time, perhaps? @Ali-7s Could we do this?

Copy link

socket-security bot commented Jun 10, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 22.2 MB kossnocorp

View full report↗︎

@Ali-7s
Copy link
Contributor Author

Ali-7s commented Jun 10, 2024

@bennettsf I agree, that would be better. Or making the events archive as soon it hits the event's end time, perhaps? @Ali-7s Could we do this?

Yeah, I just updated the code to implement it

@Ali-7s Ali-7s requested review from bennettsf and heosman June 10, 2024 23:57
@LilithLucifer3x6
Copy link

I'm late to the party but this looks great and functions as expected on my end when I create events with past due dates. Good job!

@heosman
Copy link
Contributor

heosman commented Jun 11, 2024

@bennettsf I agree, that would be better. Or making the events archive as soon it hits the event's end time, perhaps? @Ali-7s Could we do this?

Yeah, I just updated the code to implement it

@Ali-7s The events are no longer archiving with expired events or when I create events with past due dates or events that have started.

image

@Ali-7s
Copy link
Contributor Author

Ali-7s commented Jun 11, 2024

@bennettsf I agree, that would be better. Or making the events archive as soon it hits the event's end time, perhaps? @Ali-7s Could we do this?

Yeah, I just updated the code to implement it

@Ali-7s The events are no longer archiving with expired events or when I create events with past due dates or events that have started.

image

Sorry about that, it should work now based on date and event end time

Screen.Recording.2024-06-11.at.8.mp4

@heosman
Copy link
Contributor

heosman commented Jun 11, 2024

@bennettsf I agree, that would be better. Or making the events archive as soon it hits the event's end time, perhaps? @Ali-7s Could we do this?

Yeah, I just updated the code to implement it

@Ali-7s The events are no longer archiving with expired events or when I create events with past due dates or events that have started.
image

Sorry about that, it should work now based on date and event end time

Screen.Recording.2024-06-11.at.8.mp4

@Ali-7s It's working, but it seems I am only able to get an event to auto archive if the event is created using the Create Event page. Strangely, events created using Postman do not auto archive on my end. Did you create your events using the Create Event page or Postman?

@Ali-7s
Copy link
Contributor Author

Ali-7s commented Jun 11, 2024

@bennettsf I agree, that would be better. Or making the events archive as soon it hits the event's end time, perhaps? @Ali-7s Could we do this?

Yeah, I just updated the code to implement it

@Ali-7s The events are no longer archiving with expired events or when I create events with past due dates or events that have started.
image

Sorry about that, it should work now based on date and event end time
Screen.Recording.2024-06-11.at.8.mp4

@Ali-7s It's working, but it seems I am only able to get an event to auto archive if the event is created using the Create Event page. Strangely, events created using Postman do not auto archive on my end. Did you create your events using the Create Event page or Postman?

I created mine using the create event page

@heosman heosman merged commit 673a98d into main Jun 12, 2024
3 checks passed
@heosman heosman deleted the auto-archive-past-events branch June 12, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants