adopted hnsw index and fixed incorrect sql queries #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jw-mcgrath
reviewed
Jun 17, 2024
benchmark_pg_vector.py
Outdated
| cur.execute("CREATE INDEX ON documents USING HNSW (vector vector_l2_ops);") | ||
| cur.execute("CREATE INDEX ON documents USING HNSW (vector vector_cosine_ops);") | ||
| cur.execute("CREATE INDEX ON documents USING HNSW (vector vector_ip_ops);") | ||
| # conn.commit() |
jw-mcgrath
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced ivfflat to hnsw indices.
The <#> operator returns negative inner product, fixed the inner product query.
The cosine similarity should be used by subtracting it from 1 i.e. 1 - (vector <=> '[3,1,2]') as score.