Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sea query binder #361

Merged
merged 4 commits into from
Jun 26, 2022
Merged

Sea query binder #361

merged 4 commits into from
Jun 26, 2022

Conversation

tyt2y3
Copy link
Member

@tyt2y3 tyt2y3 commented Jun 26, 2022

Continue #275

@tyt2y3 tyt2y3 force-pushed the sea-query-binder branch from ef65a84 to 7d6b819 Compare June 26, 2022 07:33
@tyt2y3
Copy link
Member Author

tyt2y3 commented Jun 26, 2022

I don't want to change all existing examples to use sea-query-binder for now.
The question is how do we actually support 0.5 & 0.6 together, or only support 0.6?

@@ -25,6 +25,7 @@ sea-query-binder = { path = "../../sea-query-binder", features = [
"with-bigdecimal",
"with-uuid",
"with-time",
"postgres-array",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this feature because another crate in the workspace enabled sea-query/postgres-array, and so this cannot build

@tyt2y3 tyt2y3 merged commit ff2edab into master Jun 26, 2022
@tyt2y3 tyt2y3 deleted the sea-query-binder branch June 26, 2022 07:51
@tyt2y3
Copy link
Member Author

tyt2y3 commented Jun 26, 2022

Merged now. Feel free to create follow up PRs on any shortcomings you see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants