Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(download): Move download-related functions to 'download.ps1' #6095

Merged
merged 3 commits into from
Aug 11, 2024
Merged

refactor(download): Move download-related functions to 'download.ps1' #6095

merged 3 commits into from
Aug 11, 2024

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Aug 9, 2024 •
edited
Loading

Description

First step that refactor download-related functions.

TODOs in other PRs

  • Eliminate duplicate functions
  • Combine similar functions
  • Develop straightforward meta functions for all downloads
  • Consolidate sub-download functions across various methods
  • Enable users to choose a custom download tool

Motivation and Context

How Has This Been Tested?

Test with all related commands:

  • bin\checkhashes.ps1
  • bin\checkurls.ps1
  • bin\checkver.ps1
  • bin\describe.ps1
  • scoop download
  • scoop install
  • scoop search
  • scoop update
  • scoop virustotal

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven force-pushed the refactor-download branch 2 times, most recently from 960dbc5 to a4750c5 Compare August 9, 2024 11:08
@niheaven niheaven force-pushed the refactor-download branch from a4750c5 to 5378450 Compare August 9, 2024 11:28
@niheaven niheaven merged commit 79cf33d into develop Aug 11, 2024
2 checks passed
@niheaven niheaven deleted the refactor-download branch August 11, 2024 09:24
@niheaven niheaven mentioned this pull request Dec 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@niheaven