fix(getopt): Stop split arguments in getopt() and ensure array by explicit arguments type
#5326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-shim-to-an-exe-with-spaces-in-its-filepath
|
I'm still facing the same error: |
Exact, sorry for that, bad commit. To avoid that, I added tests. It's seem ok now. |
|
Okay, it's working now |
niheaven
reviewed
Jan 9, 2023
Better and more readable suggestion from @niheaven Co-authored-by: Hsiao-nan Cheung <[email protected]>
Better test case Co-authored-by: Hsiao-nan Cheung <[email protected]>
…paces-in-its-filepath
niheaven
changed the title
getopt() and ensure array by exlicit arguments type
niheaven
changed the title
getopt() and ensure array by exlicit arguments typegetopt() and ensure array by explicit arguments type
niheaven
force-pushed
the
5313-bug-cant-add-a-shim-to-an-exe-with-spaces-in-its-filepath
branch
from
e9e5240 to
b63c301
Compare
5 tasks
niheaven
deleted the
5313-bug-cant-add-a-shim-to-an-exe-with-spaces-in-its-filepath
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getops handle space with quote
Correct #5313
Currently, getops parse with split space. With this correction, getops is more resilient and can parse in a more robust way with quote. Previously, 'parse this "sort of text"' => parse/this/sort/of/text
Now, 'parse this "sort of text"' => parse/this/sort of text
This correction can now handle parsing path with space (ex: c:\Program Files).
Closes #5313
How Has This Been Tested?
Use bug description, test on some other cases
Checklist:
developbranch.