Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builds(auto-pr): Add CommitMessageFormat option #5171

Merged
merged 10 commits into from
Oct 14, 2022
Merged

builds(auto-pr): Add CommitMessageFormat option #5171

merged 10 commits into from
Oct 14, 2022

Conversation

yi-Xu-0100
Copy link
Contributor

@yi-Xu-0100 yi-Xu-0100 commented Oct 1, 2022 •
edited
Loading

Description

Add CommitMessageFormat option to support custom commit message for GitHub action.

Such as: CommitMessageFormat : chore: Upgrade <app> to version <version>

Motivation and Context

How Has This Been Tested?

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

lewis-yeung
lewis-yeung reviewed Oct 1, 2022
View reviewed changes
bin/auto-pr.ps1 Outdated Show resolved Hide resolved
@yi-Xu-0100 yi-Xu-0100 requested a review from lewis-yeung October 2, 2022 02:09
lewis-yeung
lewis-yeung previously approved these changes Oct 2, 2022
View reviewed changes
@niheaven
Copy link
Member

niheaven commented Oct 6, 2022

Change title and move changelog item to builds.

@yi-Xu-0100 yi-Xu-0100 changed the title feat(auto-pr): add CommitMessageFormat option builds(auto-pr): Add CommitMessageFormat option Oct 7, 2022
@yi-Xu-0100 yi-Xu-0100 requested a review from lewis-yeung October 7, 2022 08:14
@yi-Xu-0100
Copy link
Contributor Author

@niheaven The changelog has been updated. 😁

lewis-yeung
lewis-yeung previously approved these changes Oct 13, 2022
View reviewed changes
@yi-Xu-0100
Copy link
Contributor Author

@lewis-yeung @niheaven

I found a bug that $version was prepared later and will lose the version information in commitMessage. and I push a new commit(612169e) to fix it. 😅

@niheaven niheaven merged commit 512ab44 into ScoopInstaller:develop Oct 14, 2022
github-actions bot pushed a commit to pukkandan/Scoop that referenced this pull request Oct 20, 2022
@yi-Xu-0100 @github-actions
builds(auto-pr): Add CommitMessageFormat option (ScoopInstaller#5171)
17541f3
@niheaven niheaven mentioned this pull request Nov 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niheaven niheaven niheaven approved these changes

@lewis-yeung lewis-yeung lewis-yeung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yi-Xu-0100 @niheaven @lewis-yeung