(chore): Explicit declaration of source(bucket name) of suggested manifests

[HUMORCE]

Relates to ScoopInstaller/Scoop#5131

• I have read the Contributing Guide.

[rashil2000]

This seems to be a huge change: a simpler alternative would be to just prepend main/ (if nothing else is there) in Scoop core itself.

[HUMORCE]

This seems to be a huge change: a simpler alternative would be to just prepend main/ (if nothing else is there) in Scoop core itself.

Not really, many manifests from extras/versions also do not clearly identify.

Implement it in Scoop Core may breaks 3rd-party buckets and specific scenarios. this is also the reason why I have not changed depends.

Adding bucket name for suggested manifests does not affect the existing functionality and we can restore them easily.

[rashil2000]

Not really, many manifests from extras/versions also do not clearly identify.

Yes, this is precisely why I'm advocating against this. We follow a convention - a simple one - if the suggestion is from the default bucket of Scoop (i.e. Main), then no need to specify bucket, if it is from elsewhere (even official ones) we need to specify bucket.

Implement it in Scoop Core may breaks 3rd-party buckets and specific scenarios.

That's on them - they did not follow the convention. It has been present since a long time.

---

Not to mention that I'm against commits that modify so many files at once - it pollutes the git history.

---

Also, how is it related to ScoopInstaller/Scoop#5131? I mean how exactly does the suggest field let users customize bucket sorting order?

[HUMORCE]

a simple one - if the suggestion is from the default bucket of Scoop (i.e. Main), then no need to specify bucket, if it is from elsewhere (even official ones) we need to specify bucket.
Also, how is it related to ScoopInstaller/Scoop#5131? I mean how exactly does the suggest field let users customize bucket sorting order?

Scoop does not have bucket sorting settings, and the main bucket does not have the highest weight when manifest selecting.

On this premise, as a package manager Scoop must prompt|install exactly the packages that are actually suggested|depended when writing the manifest. IMO

[rashil2000]

Hmm, @niheaven any thoughts on this?

[niheaven]

It's strange that I remembered we only recommend omitting main in depends and suggest, so there're many manifests omitted extras and version as @HUMORCE said?

Okay, I've submitted a PR in Scoop Core, and please review if it could fix the bug.

[HUMORCE]

377d913, 438628c, 7c4d47a, dbab8f8, 2043138, 8b3ddd7