-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdl2-image: Add version 2.0.5 #7209
Conversation
SDL2_image is a complement to the already supported SDL2 library.
Autoupdate missing Also, please add a newline at the end |
I think this package should be in the main bucket. |
I kinda agree. @r15ch13 has made the earliest commit on the |
Co-authored-by: Issac Lin <[email protected]>
… into add-sdl2-image
Everything should be all right. |
The installer scripts are quite elaborate here, as opposed to the Main bucket's criteria. I think it should stay in Extras. |
/verify |
@niheaven wouldn't this require ScoopInstaller/Scoop#3518? |
Yes, you are right, but I think it is okay to use it now. This will just cause autoupdate to fail (thus the package will not be updated before Scoop#3518 is in master. We can choose not to add autoupdate this time, but we still need to update it manually. So it does not make any difference. |
This has to do with earlier criteria of the Main bucket. I think these criteria are abolished after late 2019, but some CLI packages still remain in the Extras bucket.
I tend to add the package to Extras for now. I think it is better to move all the CLI packages into Main, but this requires further discussion. |
Emm, lots of job 😄 But we can move whatever we meet. |
This PR add the SDL2_image library to scoop; addressing this issue.
SDL2_image is a complement to the already supported SDL2 library.
My thanks for the creators of the sdl2.json app manifest.
This PR was inspired from their work.