Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl2-image: Add version 2.0.5 #7209

Merged
merged 6 commits into from
Nov 6, 2021
Merged

sdl2-image: Add version 2.0.5 #7209

merged 6 commits into from
Nov 6, 2021

Conversation

g-berthiaume
Copy link
Contributor

This PR add the SDL2_image library to scoop; addressing this issue.
SDL2_image is a complement to the already supported SDL2 library.

My thanks for the creators of the sdl2.json app manifest.
This PR was inspired from their work.

SDL2_image is a complement to the already supported SDL2 library.
@rashil2000 rashil2000 linked an issue Nov 2, 2021 that may be closed by this pull request
@rashil2000
Copy link
Member

Autoupdate missing

Also, please add a newline at the end

bucket/sdl2_image.json Outdated Show resolved Hide resolved
@issaclin32 issaclin32 changed the title Adding sdl2_image library sdl2_image: Add version 2.0.5 Nov 2, 2021
@issaclin32
Copy link
Member

I think this package should be in the main bucket.
Also, please rename the file to sdl2-image.json, following the pattern of existing packages.

@g-berthiaume
Copy link
Contributor Author

I think this package should be in the main bucket.

I kinda agree.
That said, the SDL2 package is already in the Extra bucket.
I don't know what was the rationale for putting it there.

@r15ch13 has made the earliest commit on the sdl2.json file.
Maybe he/she would know.

@g-berthiaume
Copy link
Contributor Author

Everything should be all right.
Not sure what to think about the Extra vs Main bucket.

@rashil2000 rashil2000 changed the title sdl2_image: Add version 2.0.5 sdl2-image: Add version 2.0.5 Nov 6, 2021
@rashil2000
Copy link
Member

The installer scripts are quite elaborate here, as opposed to the Main bucket's criteria. I think it should stay in Extras.

@rashil2000
Copy link
Member

/verify

@rashil2000
Copy link
Member

@niheaven wouldn't this require ScoopInstaller/Scoop#3518?

@issaclin32
Copy link
Member

wouldn't this require ScoopInstaller/Scoop#3518?

Yes, you are right, but I think it is okay to use it now.

This will just cause autoupdate to fail (thus the package will not be updated before Scoop#3518 is in master.

We can choose not to add autoupdate this time, but we still need to update it manually. So it does not make any difference.

@rashil2000 rashil2000 requested a review from issaclin32 November 6, 2021 12:44
@issaclin32
Copy link
Member

I kinda agree. That said, the SDL2 package is already in the Extra bucket. I don't know what was the rationale for putting it there.

This has to do with earlier criteria of the Main bucket. I think these criteria are abolished after late 2019, but some CLI packages still remain in the Extras bucket.

For an app to be acceptable for the main bucket, it should be:

A reasonably well-known and widely used developer tool
The latest stable version of the program
The full version i.e. not a trial version
A fairly standard install (e.g. uses a version-specific download URL, no elaborate pre/post install scripts)
A non-GUI tool

I tend to add the package to Extras for now. I think it is better to move all the CLI packages into Main, but this requires further discussion.

@issaclin32 issaclin32 merged commit e521219 into ScoopInstaller:master Nov 6, 2021
@niheaven
Copy link
Member

niheaven commented Nov 8, 2021

I kinda agree. That said, the SDL2 package is already in the Extra bucket. I don't know what was the rationale for putting it there.

This has to do with earlier criteria of the Main bucket. I think these criteria are abolished after late 2019, but some CLI packages still remain in the Extras bucket.

For an app to be acceptable for the main bucket, it should be:

A reasonably well-known and widely used developer tool
The latest stable version of the program
The full version i.e. not a trial version
A fairly standard install (e.g. uses a version-specific download URL, no elaborate pre/post install scripts)
A non-GUI tool

I tend to add the package to Extras for now. I think it is better to move all the CLI packages into Main, but this requires further discussion.

Emm, lots of job 😄 But we can move whatever we meet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Add SDL_Image
4 participants