Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for STS #556

Merged
merged 16 commits into from
Sep 27, 2017
Merged

Support for STS #556

merged 16 commits into from
Sep 27, 2017

Conversation

javaboy79
Copy link
Contributor

Implemented #554

A few issues I could not figure out...

  1. shortcut path is version dependent, so autoupdate isn't entirely automatic
  2. shortcut created should set a target directory to the same dir as the .exe
  3. uninstall seems to choke... I suspect file paths are too long to handle gracefully, as explorer gives this warning also

@r15ch13
Copy link
Member

r15ch13 commented Sep 22, 2017

Is the stuff from pivotal-tc-server-developer-3.2.6.RELEASE not needed? If so, you could add the extract_dir property and set it to sts-bundle\sts-3.9.0.RELEASE (in autoupdate set it to sts-bundle\sts-$version.RELEASE. Then shortcut can be set to just sts.exe.

Also here is a improved version regex:

spring-tool-suite-(?<version>[\d.]+).RELEASE-e(?<eclipse>(?<short>[\d.]+).[\d]+)-win32.zip

Result:

$version = 3.9.0
$matchEclipse = 4.7.0
$matchShort = 4.7

To fix formatting run .\bin\formatjson.ps1 sts.json or .\checkver.ps1 sts -f to force an autoupdate.

Edit: There are sha1 files available! Adding the following to autoupdate should work.

"hash": { "url": "$url.sha1" }

@javaboy79
Copy link
Contributor Author

javaboy79 commented Sep 23, 2017

@r15ch13 Good eye on the sha1, I didn't notice that. This is fixed.

I plugged in your regex and it did not work exactly. I could not see where you were going with that... Wouldn't adding more matchers to the path be more error prone long term, requiring the script to be updated even if the url format changes slightly? Especially when we don't really need those bits parsed? I left the regex as is for now.

Also, I did not see a formatjson.ps1 script in the bin dir. It does seem to pass build now though.

As for setting the extract_dir.. Yes, as far as I know pivotal-tc-server-developer-3.2.6.RELEASE is required. It is referenced from STS and I think without it STS is slightly crippled. The whole bundle is what makes STS, well, STS. If you tear it apart, you just end up with Eclipse + Spring plugin. So I do not think extract_dir should be set.

Any comment on how to give the created shortcut a Start in: directory? Or the uninstall problem I mentioned?

@rasa
Copy link
Member

rasa commented Sep 23, 2017

@r15ch13
Copy link
Member

r15ch13 commented Sep 24, 2017

@javaboy79
Copy link
Contributor Author

@r15ch13 I have incorporated all the recommend changes and also add a bin value. Please review.

@r15ch13 r15ch13 merged commit 26b116b into ScoopInstaller:master Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants