-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for STS #556
Support for STS #556
Conversation
Is the stuff from Also here is a improved version regex: spring-tool-suite-(?<version>[\d.]+).RELEASE-e(?<eclipse>(?<short>[\d.]+).[\d]+)-win32.zip Result:
To fix formatting run Edit: There are sha1 files available! Adding the following to "hash": { "url": "$url.sha1" } |
@r15ch13 Good eye on the sha1, I didn't notice that. This is fixed. I plugged in your regex and it did not work exactly. I could not see where you were going with that... Wouldn't adding more matchers to the path be more error prone long term, requiring the script to be updated even if the url format changes slightly? Especially when we don't really need those bits parsed? I left the regex as is for now. Also, I did not see a As for setting the extract_dir.. Yes, as far as I know Any comment on how to give the created shortcut a |
|
@r15ch13 I have incorporated all the recommend changes and also add a |
Implemented #554
A few issues I could not figure out...