Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qbittorrent-portable: add #2014

Merged
merged 6 commits into from
Apr 17, 2019
Merged

qbittorrent-portable: add #2014

merged 6 commits into from
Apr 17, 2019

Conversation

Skrity
Copy link
Contributor

@Skrity Skrity commented Apr 16, 2019

No description provided.

@Ash258
Copy link
Contributor

Ash258 commented Apr 16, 2019

I would wait for one of these is merged: qbittorrent/qBittorrent#9584 qbittorrent/qBittorrent#9349 and then add qbittorrent-portable to extras, keeping nonportable available

bucket/qbittorrent.json Outdated Show resolved Hide resolved
@Skrity
Copy link
Contributor Author

Skrity commented Apr 16, 2019

I see merit in keeping qbittorrent intact if only for compatibility with previous installations.
As for portability: I imagine that env_set will break installation of qbittorrent alongside qbittorrent-portable, maybe something like this can work meanwhile we wait for a proper portable edition?

    "bin": [ 
        [
            "qbittorrent.exe",
            "qbittorrent",
            "--portable" 
        ]
    ],
    "shortcuts": [
        [
            "qbittorrent.exe",
            "qBittorrent",
            "--portable" 
        ]
    ],

@Ash258
Copy link
Contributor

Ash258 commented Apr 16, 2019

@Skrity Skrity changed the title qbittorrent: make portable, persist qbittorrent-portable: add Apr 16, 2019
bucket/qbittorrent-portable.json Outdated Show resolved Hide resolved
bucket/qbittorrent-portable.json Outdated Show resolved Hide resolved
bucket/qbittorrent-portable.json Outdated Show resolved Hide resolved
bucket/qbittorrent.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants