Deprecate nextRunList(), new target platforms and more #20

Myshkouski · 2024-01-08T14:50:24Z

Changelog:

8b1d94f - Implement 'asIterable' method:
nextRunList() returns List<LocalDateTime> and doesn't allow to specify datetime to start iterate with, so there is no way to get results for specific period (i.e. "return next run list for period starting from 2050-01-01T10:00:00 to 2050-01-01T11:00:00"). asIterable(start: LocalDateTime) gives some advantages:
- now you could specify start datetime to start iterate from and collect result untill some end date (i.e. cronBuilder.asIterable(someStartDateTime).takeWhile { dateTime -> dateTime < someEndDateTime });
- no need to store all values in a list by calling cronBuilder.asIterable(someStartDateTime).asSequence();
d23fc9ce - Support linuxArm64 and macosArm64 targets

deprecate 'nextRunList' method

.gitignore

build.gradle.kts

src/commonMain/kotlin/com/ucasoft/kcron/builders/Builder.kt

Scogun · 2024-01-08T16:03:33Z

Hello @Myshkouski!
Thank you a lot for the great contributing!
However, beside comments on file there are couple more:

Increase version at least up to 0.9.0
Update README file (old nextRunList could be removed)
There should be unit tests which cover new functionality.

You can ignore Sonar warning except a one (related to this comment).
I also will check why the test action is failing.

Scogun · 2024-01-08T16:08:09Z

Also, should we also deprecate nextRun property? Or rename to nextRunFromNow, for example?

Scogun · 2024-01-08T16:58:08Z

@Myshkouski could you also change pull_request on pull_request_target here?

build.gradle.kts

see Scogun#20 (comment)

Myshkouski · 2024-01-08T20:06:03Z

Also, should we also deprecate nextRun property? Or rename to nextRunFromNow, for example?

Changed getter implementation in 76f9e59.

If you are not actually require I'll deprecate it in next pull requests.

see Scogun#20 (comment)

Myshkouski · 2024-01-08T20:33:54Z

@Myshkouski could you also change pull_request on pull_request_target here?

Updated in 238411f

Scogun

Waiting for build.gradle.kts revert and version and README update.

deprecate 'nextRunList' method

see Scogun#20 (comment)

Scogun · 2024-01-08T23:55:40Z

So, I fixed the action.
Last steps:

Revert signin.skip
Add at least one unit test which will cover new functionality
Increase version at least up to 0.9.0
Change README

CC: @Myshkouski

This reverts commit d8467f3.

This reverts commit 26afced.

Scogun · 2024-01-09T09:38:48Z

Remaining steps:

Add at least one unit test which will cover new functionality
Increase version at least up to 0.9.0
Change README

CC: @Myshkouski

This reverts commit 62c8de4.

build.gradle.kts

This reverts commit 5f898b5.

Myshkouski · 2024-01-09T10:22:09Z

Remaining steps:

Add at least one unit test which will cover new functionality

Increase version at least up to 0.9.0

Change README

CC: @Myshkouski

Done:

Add at least one unit test which will cover new functionality
Increase version at least up to 0.9.0
Change README

Scogun · 2024-01-09T10:50:18Z

README.md

@@ -102,6 +103,6 @@ builder.years(2021..2025)
 println(builder.expression) // 0/10 5-25 5,12 ? * SUN#5 2021-2025
 ``` 
 ### Current status
-This library is on beta version `0.8.0`.
+This library is on beta version `0.9.0`.


There is also the version in this lines:

one

two

Scogun · 2024-01-09T10:52:14Z

src/commonTest/kotlin/com/ucasoft/kcron/builders/BuilderTests.kt

@@ -10,6 +10,7 @@ import io.kotest.matchers.shouldBe
 import kotlinx.datetime.*
 import kotlin.test.Test

+@OptIn(DelicateIterableApi::class)
 class BuilderTests {

    @Test


Also add new test where expression will start from 2050, for example, but asIterable() will be called from 2060.

Scogun · 2024-01-09T10:53:16Z

@Myshkouski almost there.

sonarqubecloud · 2024-01-09T12:18:10Z

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Scogun · 2024-01-09T12:33:25Z

Approved!
However, I will release after few additional changes.

Myshkouski added 6 commits January 4, 2024 03:48

implement 'asIterable' method

8b1d94f

deprecate 'nextRunList' method

KCron -> Cron

086a775

implement signing skip for dev/test environments

5f898b5

add opt-in annotations

05fd35e

fix spelling

bf5b25d

fix when no 'signing.skip' property exist

62c8de4

Scogun requested changes Jan 8, 2024

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

build.gradle.kts Outdated Show resolved Hide resolved

build.gradle.kts Outdated Show resolved Hide resolved

src/commonMain/kotlin/com/ucasoft/kcron/builders/Builder.kt Show resolved Hide resolved

Scogun reviewed Jan 8, 2024

View reviewed changes

src/commonMain/kotlin/com/ucasoft/kcron/builders/Builder.kt Outdated Show resolved Hide resolved

update kotlin version to latest

78c569e

Scogun reviewed Jan 8, 2024

View reviewed changes

build.gradle.kts Show resolved Hide resolved

Myshkouski added 2 commits January 8, 2024 22:59

implement asIterable() with default start set to now()

f78076e

see Scogun#20 (comment)

use new method for 'nextRun'

76f9e59

Myshkouski added 2 commits January 8, 2024 23:15

update developers section

49897b8

update github workflow

238411f

see Scogun#20 (comment)

Scogun self-requested a review January 8, 2024 22:27

Scogun reviewed Jan 8, 2024

View reviewed changes

Myshkouski added 9 commits January 8, 2024 23:40

implement 'asIterable' method

862ede1

deprecate 'nextRunList' method

KCron -> Cron

8b91b76

implement signing skip for dev/test environments

26afced

add opt-in annotations

9b4f68e

fix spelling

8614372

fix when no 'signing.skip' property exist

d8467f3

update kotlin version to latest

80bb339

implement asIterable() with default start set to now()

197e899

see Scogun#20 (comment)

use new method for 'nextRun'

d5d0f4b

update developers section

fffa268

Scogun force-pushed the next branch from 238411f to fffa268 Compare January 8, 2024 22:40

support linuxArm64 and macosArm64 targets

d23fc9c

Myshkouski added 2 commits January 9, 2024 11:35

Revert "fix when no 'signing.skip' property exist"

3719e28

This reverts commit d8467f3.

Revert "implement signing skip for dev/test environments"

f0cc4df

This reverts commit 26afced.

Myshkouski added 2 commits January 9, 2024 12:53

Merge remote-tracking branch 'origin/support-arm64-targets' into next

304f67e

Revert "fix when no 'signing.skip' property exist"

498bec9

This reverts commit 62c8de4.

Scogun requested changes Jan 9, 2024

View reviewed changes

build.gradle.kts Outdated Show resolved Hide resolved

Myshkouski added 4 commits January 9, 2024 13:01

Revert "implement signing skip for dev/test environments"

5b2d5b7

This reverts commit 5f898b5.

replace nextRunList(n) with asIterable().take(n) in tests

b659814

update readme

a2b6e20

update version

c0d7ffd

Myshkouski changed the title ~~Deprecate nextRunList(), gradle local config and more~~ Deprecate nextRunList(), new target platforms and more Jan 9, 2024

update version

d4af205

Myshkouski requested a review from Scogun January 9, 2024 10:30

Scogun requested changes Jan 9, 2024

View reviewed changes

Myshkouski added 2 commits January 9, 2024 15:14

add tests for 'asIterable(start: LocalDateTime)'

486b99c

update version

fc0b416

Scogun approved these changes Jan 9, 2024

View reviewed changes

Scogun merged commit 9c9007e into Scogun:main Jan 9, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate nextRunList(), new target platforms and more #20

Deprecate nextRunList(), new target platforms and more #20

Myshkouski commented Jan 8, 2024 •

edited

Loading

Scogun commented Jan 8, 2024 •

edited

Loading

Scogun commented Jan 8, 2024

Scogun commented Jan 8, 2024

Myshkouski commented Jan 8, 2024 •

edited

Loading

Myshkouski commented Jan 8, 2024

Scogun left a comment

Scogun commented Jan 8, 2024

Scogun commented Jan 9, 2024 •

edited

Loading

Myshkouski commented Jan 9, 2024 •

edited

Loading

Scogun Jan 9, 2024 •

edited

Loading

Scogun Jan 9, 2024

Scogun commented Jan 9, 2024

sonarqubecloud bot commented Jan 9, 2024

Scogun commented Jan 9, 2024

Deprecate nextRunList(), new target platforms and more #20

Deprecate nextRunList(), new target platforms and more #20

Conversation

Myshkouski commented Jan 8, 2024 • edited Loading

Scogun commented Jan 8, 2024 • edited Loading

Scogun commented Jan 8, 2024

Scogun commented Jan 8, 2024

Myshkouski commented Jan 8, 2024 • edited Loading

Myshkouski commented Jan 8, 2024

Scogun left a comment

Choose a reason for hiding this comment

Scogun commented Jan 8, 2024

Scogun commented Jan 9, 2024 • edited Loading

Myshkouski commented Jan 9, 2024 • edited Loading

Scogun Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

Scogun Jan 9, 2024

Choose a reason for hiding this comment

Scogun commented Jan 9, 2024

sonarqubecloud bot commented Jan 9, 2024

Quality Gate passed

Scogun commented Jan 9, 2024

Myshkouski commented Jan 8, 2024 •

edited

Loading

Scogun commented Jan 8, 2024 •

edited

Loading

Myshkouski commented Jan 8, 2024 •

edited

Loading

Scogun commented Jan 9, 2024 •

edited

Loading

Myshkouski commented Jan 9, 2024 •

edited

Loading

Scogun Jan 9, 2024 •

edited

Loading