Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we replace sharks with blahaj ? #8990

Closed
Tracked by #6090
FirelightFlagboy opened this issue Nov 25, 2024 · 3 comments · Fixed by #9309
Closed
Tracked by #6090

Should we replace sharks with blahaj ? #8990

FirelightFlagboy opened this issue Nov 25, 2024 · 3 comments · Fixed by #9309
Assignees
@vxgmichel
Labels
A-Client Area: Parsec desktop application I-Dependency Impact: related to an dependency I-Rust Impact: Rust-related stuff

Comments

@FirelightFlagboy
Copy link
Contributor

FirelightFlagboy commented Nov 25, 2024 •
edited
Loading

sharks is the rust crate we use to provide Shamir support.
That crate did not receive any updates since 2021 and the vulnerability RUSTSEC-2024-0398 was found in it.

The crate blahaj is a fork of sharks that fix that vulnerability. That fork was created because apparently the owner of sharks was not reachable.
FirelightFlagboy added a commit that referenced this issue Nov 25, 2024
@FirelightFlagboy
Ignore RUSTSEC-2024-0398
57a24c4 
Related to #8990
@FirelightFlagboy FirelightFlagboy added A-Client Area: Parsec desktop application I-Dependency Impact: related to an dependency I-Rust Impact: Rust-related stuff labels Nov 25, 2024
@vxgmichel
Copy link
Contributor

vxgmichel commented Nov 25, 2024 •
edited
Loading

+1 on migrating, the change is minor so our code won't need to be updated

github-merge-queue bot pushed a commit that referenced this issue Nov 25, 2024
@FirelightFlagboy
Ignore RUSTSEC-2024-0398
4bae494 
Related to #8990
FirelightFlagboy added a commit that referenced this issue Nov 28, 2024
@FirelightFlagboy
Ignore RUSTSEC-2024-0398
4c0bd83 
Related to #8990
FirelightFlagboy added a commit that referenced this issue Nov 28, 2024
@FirelightFlagboy
Ignore RUSTSEC-2024-0398
5e67f47 
Related to #8990
FirelightFlagboy added a commit that referenced this issue Dec 13, 2024
@FirelightFlagboy
Ignore RUSTSEC-2024-0398
5360344 
Related to #8990
FirelightFlagboy added a commit that referenced this issue Dec 19, 2024
@FirelightFlagboy
Ignore RUSTSEC-2024-0398
50dcc3f 
Related to #8990
@mmmarcos
Copy link
Contributor

mmmarcos commented Jan 6, 2025

@Landeers I recall there were some discussions regarding the sharks lib for the Resana project. Is this change OK for you?

@Landeers
Copy link
Contributor

Landeers commented Jan 8, 2025

@Landeers I recall there were some discussions regarding the sharks lib for the Resana project. Is this change OK for you?

OK for me

@mmmarcos mmmarcos mentioned this issue Jan 8, 2025
Closed
13 tasks
@vxgmichel vxgmichel mentioned this issue Jan 9, 2025
Merged
FirelightFlagboy added a commit that referenced this issue Jan 15, 2025
@FirelightFlagboy
Ignore RUSTSEC-2024-0398
a0dc748 
Related to #8990
FirelightFlagboy added a commit that referenced this issue Jan 16, 2025
@FirelightFlagboy
Ignore RUSTSEC-2024-0398
9c4c746 
Related to #8990
FirelightFlagboy added a commit that referenced this issue Jan 16, 2025
@FirelightFlagboy
Ignore RUSTSEC-2024-0398
4f057ec 
Related to #8990
FirelightFlagboy added a commit that referenced this issue Jan 16, 2025
@FirelightFlagboy
Ignore RUSTSEC-2024-0398
1b0a71a 
Related to #8990
FirelightFlagboy added a commit that referenced this issue Jan 17, 2025
@FirelightFlagboy
Ignore RUSTSEC-2024-0398
331a92d 
Related to #8990
vxgmichel pushed a commit that referenced this issue Jan 17, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
0467065 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
FirelightFlagboy added a commit that referenced this issue Jan 21, 2025
@FirelightFlagboy
Ignore RUSTSEC-2024-0398
c139f0e 
Related to #8990
FirelightFlagboy added a commit that referenced this issue Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
d4bc2ba 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
FirelightFlagboy added a commit that referenced this issue Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
bdaef8f 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
FirelightFlagboy added a commit that referenced this issue Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
9f3a2dd 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
FirelightFlagboy added a commit that referenced this issue Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
5c10273 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
a901b68 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
0af9419 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vxgmichel vxgmichel

Labels
A-Client Area: Parsec desktop application I-Dependency Impact: related to an dependency I-Rust Impact: Rust-related stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate from sharks to blahaj Scille/parsec-cloud
4 participants
@mmmarcos @vxgmichel @Landeers @FirelightFlagboy