Lang providers #736
Merged
Lang providers #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixar02
added
the
language
JoeyDP
requested changes
May 25, 2023
# Conflicts: # src/main/resources/assets/minelabs/lang/nl_nl.json
# Conflicts: # src/main/generated/assets/minelabs/lang/en_us.json # src/main/generated/assets/minelabs/lang/nl_be.json # src/main/resources/assets/minelabs/lang/en_us.static.json # src/main/resources/assets/minelabs/lang/nl_nl.json
JoeyDP
approved these changes
Jun 28, 2023
# Conflicts: # src/main/resources/assets/minelabs/lang/en_us.static.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Lang Providers. fixes #722
It will generate all blocks items and block entities that we add to the game automatically. (When running Datagen or when building the jar)
If you have any manual entries you want to add (text/itemgroups/villager professions/...):
Add the
keyin MinelabsLangProvider (with either an empty translation or a predefined stringmissing_translation)You can then choose to add the the correct translation for each Lang in the respective provider (making them Dynamic for when we change subfolders / identifiers) OR add it to the STATIC lang file which we have to manually update.
Notes: