Mesh nonexperimental extra #6077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
added
the
benchmark_this
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6077 +/- ##
==========================================
+ Coverage 89.69% 89.75% +0.05%
==========================================
Files 91 88 -3
Lines 22997 22976 -21
Branches 5026 5022 -4
==========================================
- Hits 20627 20621 -6
+ Misses 1640 1624 -16
- Partials 730 731 +1 ☔ View full report in Codecov by Sentry. |
This was referenced Jul 23, 2024
Merged
pp-mo
force-pushed
the
mesh_nonexperimental_extra
branch
4 times, most recently
from
1bc7b9c to
6317b16
Compare
Replace experiment.ugrid, including docstrings and imports. Fix test_ParseUgridOnLoad Fix ugrid.load. Remove PARSE_UGRID from t/i/ugrid/test_ugrid_save Remove PARSE_UGRID from t/u/ff/nc/saver/test_save Remove PARSE_UGRID from t/i/exp/geovista/(both) Remove PARSE_UGRID from t/u/tests/stock/test_netcdf
…mental.ugrid only. missed
pp-mo
force-pushed
the
mesh_nonexperimental_extra
branch
2 times, most recently
from
f97a563 to
8fa7e07
Compare
Removed obsolete tests.unit.metadata
fix Fix iris.mesh import in tests/stock/__init__
Fix experimental.ugrid import of save_mesh
pp-mo
force-pushed
the
mesh_nonexperimental_extra
branch
from
8fa7e07 to
f0c8a02
Compare
Fix imports in cf ugrid tests.
pp-mo
force-pushed
the
mesh_nonexperimental_extra
branch
from
4b2ded4 to
32c264e
Compare
|
@bjlittle think this is finally worth looking at. |
Closed
bjlittle
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
@pp-mo A brilliant piece of work, thanks! 🍻
In general, the migration of iris.experimental.ugrid and particularly refactoring of the API into the core iris.mesh module along with pushing relevant supporting mesh behaviour into other core modules e.g., iris.common.metadata is lovely to see 💯🥳
So glad to see us dropping the context manager by default for a cleaner "no faff" user experience 👍
pp-mo
added
benchmark_this
stephenworsley
added a commit
to stephenworsley/iris
that referenced
this pull request
Jul 26, 2024
* main: Mesh nonexperimental extra (SciTools#6077) Mesh nonexperimental (SciTools#6061) # Conflicts: # lib/iris/experimental/ugrid/cf.py
This was referenced Jul 26, 2024
⏱️ Performance Benchmark Report: 4585059Performance shiftsFull benchmark resultsGenerated by GHA run |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jul 30, 2024
* upstream/main: Load performance improvement (ignoring UGRID) (SciTools#6088) Adding monthly and yearly arguments to `guess_bounds` (SciTools#6090) Mesh nonexperimental extra (SciTools#6077) Mesh nonexperimental (SciTools#6061) Bump scitools/workflows from 2024.07.4 to 2024.07.5 (SciTools#6076) Updated environment lockfiles (SciTools#6068) Enable UGRID loading always; deprecate PARSE_UGRID_ON_LOAD. (SciTools#6054) Bump scitools/workflows from 2024.07.3 to 2024.07.4 (SciTools#6071)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on for #6061
Given which..
Closes #6057