-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary fix for airspeed-velocity/asv#1396 #5931
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5931 +/- ##
==========================================
+ Coverage 89.76% 89.78% +0.01%
==========================================
Files 93 93
Lines 22982 23007 +25
Branches 5006 5017 +11
==========================================
+ Hits 20630 20657 +27
+ Misses 1622 1620 -2
Partials 730 730 ☔ View full report in Codecov by Sentry. |
⏱️ Performance Benchmark Report: 28090ccPerformance shifts
Full benchmark results
Generated by GHA run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
⏱️ Performance Benchmark Report: 9a1b01fPerformance shifts
Full benchmark results
Generated by GHA run |
Thanks @stephenworsley! |
🚀 Pull Request
Description
See airspeed-velocity/asv#1396. The fix has been proposed in airspeed-velocity/asv#1397 but it is uncertain how quickly that might progress. We need the benchmarks working for an upcoming sprint, including in places where we cannot pin the Conda version appropriately, so I am proposing this temporary override in our existing subclass.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: