Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid computing lazy scalar coordinates when printing a Cube #5788

Closed
wants to merge 1 commit into from

Conversation

fnattino
Copy link
Contributor

🚀 Pull Request

Description

The point and bound of a scalar coordinate are printed out only when the corresponding data is not lazy. Fix #5743.


Consult Iris pull request check list

@CLAassistant
Copy link

CLAassistant commented Feb 27, 2024

CLA assistant check
All committers have signed the CLA.

@trexfeathers trexfeathers requested a review from pp-mo February 27, 2024 09:52
@trexfeathers trexfeathers removed the request for review from pp-mo February 29, 2024 14:31
@pp-mo
Copy link
Member

pp-mo commented Mar 28, 2024

Note: we are planning now a minor "interim" release to include #5833 and #5740
Ping @trexfeathers can we fit this in ?

Status : I think ..

@pp-mo
Copy link
Member

pp-mo commented Apr 2, 2024

@fnattino if it's ok with you, I'm going to take this + add a couple of commits to fix + extend the testing slightly.
Then we can bank it.
Because we're intending to cut Iris 3.9.0.rc0 today

@trexfeathers
Copy link
Contributor

Because we're intending to cut Iris 3.9.0.rc0 today

tomorrow*

@ESadek-MO
Copy link
Contributor

Completed in #5896 .

@ESadek-MO ESadek-MO closed this Apr 3, 2024
@fnattino
Copy link
Contributor Author

fnattino commented Apr 3, 2024

Many apologies for the lack of response, I have been busy with other things recently and away for the last week or so. Thanks a lot @pp-mo for picking this up, happy to hear #5896 has been merged.

@pp-mo
Copy link
Member

pp-mo commented Apr 3, 2024

Many apologies for the lack of response, I have been busy with other things recently and away for the last week or so. Thanks a lot @pp-mo for picking this up, happy to hear #5896 has been merged.

No problem at all. Thanks for contributing !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cube printout should not compute lazy scalar coordinates
5 participants