Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stale gha #4268

Merged
merged 5 commits into from
Aug 3, 2021
Merged

add stale gha #4268

merged 5 commits into from
Aug 3, 2021

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Aug 3, 2021

🚀 Pull Request

Description

This PR adds the stale GHA in order to help maintain a healthy issues and prs backlog.


Consult Iris pull request check list

@bjlittle
Copy link
Member Author

bjlittle commented Aug 3, 2021

I guess the proposed days-before-stale and days-before-close values are the main thing up for debate.

If it helps, here is a plot of the number of issues that would not be considered stale for the given dates or days since now (3 Aug 2021) e.g., for the proposed days-before-stale of 1000 which is 7 Nov 2018, approximately 159 issues would remain not marked as stale out of 295.

stale_since

@bjlittle bjlittle requested a review from jamesp August 3, 2021 07:53
@jamesp
Copy link
Member

jamesp commented Aug 3, 2021

I think this is a great idea. I'd be all in favour of a shorter days-before-stale. Realistically, if we haven't addressed it in 365 days it's probably never going to get addressed, and the project will have moved on significantly from this point of raising.

@bjlittle
Copy link
Member Author

bjlittle commented Aug 3, 2021

@jamesp Personally, happily move south of 1000... the associated GH Discussion seeded the initial value.

i.e., a days-before-stale of 500 (21 Mar 2020) would leave 70 issues open.

I'm happy to go with the crowd on this one, as long as there isn't too much protracted debate. I think we just need to make a call. At the end of the day closed issues and prs can be re-opened... it's not the end of the world, but from our perspective as maintainers we could actually really own the issues backlog for the first time in many, many years.

... we'd just need to commit to keeping on top of it, but that's on us as maintainers.

Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over on the discussion, there was talk of starting with a 3 year lead, and then gradually reducing. I think starting with a smaller number of stale issues makes sense, because we can see what kind of activity (if any) is generated by people re-engaging. It would be a shame if someone did re-engage but we didn't have time to address their comments.

On the gap between stale and closed, I would have said at least a month, as it gives time for people who are on holiday or otherwise away. So 28 days seems OK to me, but I wouldn't want to go any lower.

@bjlittle
Copy link
Member Author

bjlittle commented Aug 3, 2021

@jamesp Did you want an associated whatsnew entry? I'm really not fussed...

@jamesp
Copy link
Member

jamesp commented Aug 3, 2021

No I don't think it's necessary, thanks @bjlittle!

@jamesp jamesp merged commit 8944143 into SciTools:main Aug 3, 2021
@bjlittle bjlittle deleted the gha-stale-issues-and-prs branch September 8, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants