-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI environment lockfiles #4137
Conversation
Oh dear, we may have to blame the new |
Aha! #3687 explains why previous behaviour != historical behaviour. |
py38 is still getting a |
Hmm, why has cython become a dependency? It wasn't in the previous build. |
It was introduced for cf-units in |
I would have thought that would only be a build dependency, not required to run cf-units |
Ah, yes, thanks. Didn't spot that fine distinction. Does that suggest one of the other changed dependencies has brought cython with it? |
Very odd, I'm not sure. I have a script somewhere that can read a lock file and tell you want depends on what. I'll dust it off and see if I can run it over this new version |
036fc16
to
81ecec3
Compare
It seems the latest update has clobbered the commit from #4139 ☹ |
81ecec3
to
7178e45
Compare
@bjlittle informs me that |
@jamesp
If this is a problem, can you re-run to get the latest and greatest? |
7178e45
to
84e5160
Compare
Ok, since #4163 has now gone in this is only resolving py37 and py38 environments which is great. But now we're seeing inconsistencies between handling |
It sounds related to cftime, but I don't know why there would be different behaviours between Python versions. |
Here's the diff between the two lock files
Strange that the py37 is still using the old python-stratify |
|
@trexfeathers @rcomer either of you want the honours of merging this? |
👀 🎉 |
* master: refactor setup.py to setup.cfg (SciTools#4168) update docs pypi release (SciTools#4173) Update CI environment lockfiles (SciTools#4137) update CONTRIBUTING.md (SciTools#4165) RTD support link update (SciTools#4166) drop py36 support (SciTools#4163) github issues contact link for discussions (SciTools#4164) Bump black version (SciTools#4162) Stop CI from clobbering commits on lockfile updates (SciTools#4157) [pre-commit.ci] pre-commit autoupdate (SciTools#4161) Add a method to return a CubeList from CubeList.copy() (SciTools#4094) Update black et al (SciTools#4155)
Lockfiles updated to the latest resolvable environment.