Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version pin on proj4. #3353

Closed
wants to merge 2 commits into from
Closed

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Jul 10, 2019

DO NOT MERGE (yet)

Check to see if tests still fail when removing this constraint

@pp-mo
Copy link
Member Author

pp-mo commented Jul 10, 2019

if tests still fail when removing this constraint
No they don't !!

So I do think this is obsolete.
This is stopping (making skip) all the tests of the iris-grib interface.
Fixing those will unblock #2608

That still requires additional work, but I think this part is crucial.
Coming up ... use eccodes + get later iris-grib, ( ? with conda in place of pip ?).

@pp-mo pp-mo force-pushed the unpin_proj4 branch 2 times, most recently from 301d318 to 8a332e3 Compare July 10, 2019 17:28
@bjlittle
Copy link
Member

@pp-mo We're using pip and at the moment eccodes-python is only available on PyPI - this is the only version that works in Python3 at the moment. Offline we can help the ECMWF package with conda.

@bjlittle bjlittle added this to the v2.3.0 milestone Jul 10, 2019
@pp-mo
Copy link
Member Author

pp-mo commented Jul 11, 2019

We're using pip and at the moment eccodes-python is only available on PyPI

Ok, I was hoping to simplify here, but that explains it.
I can probably modify this, copying the iris-grib testing approach, to get Python3 testing working also.

In the meantime, I see we now have a bunch of things that look like they aren't compatible between gribapi and eccodes -- but presumably none of these are tested in iris-grib itself.
Some of this testing probably still wants to be migrated out of iris : We still have a heap of tech debt in iris-grib!!

@bjlittle
Copy link
Member

bjlittle commented Jul 11, 2019

@pp-mo So what are you intentions for this particular PR?

Seems like you are pulling on quite a few strings that reach across into iris-grib, eccodes,python-eccodes (Python2) and (confusingly) eccodes-python (Python3).

@pp-mo
Copy link
Member Author

pp-mo commented Aug 22, 2019

Let's kill this off
and replace with a PR that just unpins proj4 like it says on the box 😉 == #3374
and create a separate issue to address getting iris-grib interface testing back up == #3375

@pp-mo pp-mo closed this Aug 22, 2019
@pp-mo pp-mo deleted the unpin_proj4 branch July 13, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants