Removal of TEST_COMPAT and OLD_XML code #31
Conversation
| @iris.tests.skip_data | ||
| class TestRegrid(tests.IrisTest): | ||
| @staticmethod | ||
| def patch_data(cube): |
There was a problem hiding this comment.
How were the tests working before this?
There was a problem hiding this comment.
There was a function old_style() that in addition to some TEST_COMPAT code also removed the surface_altitude coord and the cube's aux_factory.
|
Looks good. We all seem to be working on very similar things so were getting quite a few conflict. Hopefully that will die down soon, but as it is, it will need re-basing inorder to merge. My advice would be to wait for #34 to go onto master before doing the rebase. |
|
Thanks Phil. |
Actually, I'm not sure about this statement anymore. It seems they are pretty independent after all. |
|
What about all the updated cml results, shouldn't they be bundled in with this work? |
Not sure what you mean? FYI #21 implemented the new xml. |
|
Ah, yes, um. cough. That's what I thought. |
|
I've rebased this against upstream/master so it can be automatically merged. |
Removal of TEST_COMPAT and OLD_XML code
Fixes issue #26.
Also converted remaining netcdf_units cml results file to new XML format and changed erroneous .nc file extension to .cml.