Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iris3 coord units #214

Closed
wants to merge 4 commits into from
Closed

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Jun 24, 2020

WIP: DO NOT MERGE
until we have Iris3, and this is re-tested + OK

Closes #207

These changes will be needed when we release the changes on iris default_units feature-branch
(but which is not yet merged, hence WIP flag).
They just ensure "units=1", for unchanged behaviour when creating coords.
That is anyway benign : it all works with current Iris.

( checked out locally, against the Iris feature-branch current content )

@coveralls
Copy link

coveralls commented Jun 24, 2020

Coverage Status

Coverage remained the same at 92.482% when pulling 0e2afbc on pp-mo:fix_iris3_coord_units into 4b7797f on SciTools:master.

@pp-mo
Copy link
Member Author

pp-mo commented Jun 25, 2020

Outstanding Questions :

  • model_level_number now has "no_units" in Iris PP loading - is that right??
    • - ok, checked that units=1 is expected for both PP and netcdf data in Iris test CDLs iris/tests/results/...
  • satellite series/number/type numbers : units=1, maybe some should be "no_unit" instead ?
    • - not so clear, maybe needs checking against satellite knowledge : can we see some netcdf coded data of the same type ?

@pp-mo pp-mo modified the milestones: v0.16, v0.16.0 Jun 25, 2020
@pp-mo pp-mo mentioned this pull request Sep 30, 2020
@pp-mo
Copy link
Member Author

pp-mo commented Oct 1, 2020

Added 2 new commits to fix for recent changes in Iris : Notably from SciTools/iris#3804, which has rationalised types of coordinate-system properties (most are now cast to floats)

This tested all passed with this recent Iris commit

@pp-mo
Copy link
Member Author

pp-mo commented Oct 6, 2020

Now done in #231

@pp-mo pp-mo closed this Oct 6, 2020
@pp-mo pp-mo deleted the fix_iris3_coord_units branch March 3, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check behaviour with Iris 3.0-style Coord changes
2 participants