Update pyproject.toml and .pre-commit-config.yaml for common SciTools standards #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HGWright
requested changes
Nov 18, 2024
.pre-commit-config.yaml
Outdated
| noxfile\.py| | ||
| pyproject\.toml| | ||
| setup\.py| | ||
| src\/.+\.py |
There was a problem hiding this comment.
This doesn't seen necessary since we don't have a src file. Although it doesn't seem like it is a problem since its not causing errors.
Comment on lines
+73
to
+82
| [tool.repo-review] | ||
| ignore = [ | ||
| # https://learn.scientific-python.org/development/guides/style/#PC170 | ||
| "PC170", # PyGrep hooks | ||
| # https://learn.scientific-python.org/development/guides/style/#PC180 | ||
| "PC180", # Uses prettier | ||
| "PY005", # Test folder location | ||
| "GH104", # Unique names for upload artifact | ||
| "GH212", # Require GHA update grouping | ||
| ] |
There was a problem hiding this comment.
Seems inconsistent to do the link for 2 and not all, your call if you want to remove the links that are there or add the rest.
There was a problem hiding this comment.
The other equivalent links don't work, I agree it does make it look a bit odd with just two though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up issue here #437