Interpolating Adjoint possible test fix #1162
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
I was getting some test failures in the adjoint tests when testing SciML/OrdinaryDiffEq.jl#2567
https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/13182182796/job/36795499058?pr=2567
It looks like in one of the interpolating adjoint tests, the value of
t
was going slightly above the highest value of the last interval. This was causingfindcursor(intervals,t)
to return one higher than the length of intervals, so there would be an error when trying to use that as an index tointervals
. This fixes the issue, but I'm not sure that it's the correct thing to do, given that probablyt
should never be higher than the highest value of the last interval in the first place.