Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more CI #113

Merged
merged 2 commits into from
Feb 26, 2024
Merged

more CI #113

merged 2 commits into from
Feb 26, 2024

Conversation

ArnoStrouwen
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.72%. Comparing base (7de77b3) to head (efaf03a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files           4        4           
  Lines         359      359           
=======================================
  Hits          297      297           
  Misses         62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArnoStrouwen
Copy link
Member Author

ArnoStrouwen commented Jan 11, 2024

SciML is moving to throwing errors on hitting deprecation in CI.

I have no idea where the deprecation warning for Catalyst.@register is coming from. The Catalyst version the CI is using does not seem to still use Catalyst.@register? @TorkelE do you have any idea?

@ChrisRackauckas
Copy link
Member

It should be @symbolic_register

@ArnoStrouwen
Copy link
Member Author

In Catalyst, everything seems to be the other way around: @register_symbolic.

@isaacsas
Copy link
Member

I can’t find anywhere that @register is being used in Catalyst, here, or MTK. Maybe this is some aqua-related issue? I was finding it was giving what seemed like spurious ambiguities at times. Maybe it would be easier to first get these CI additions working with MTK and then Catalyst before here so we can know there aren't issues with lower-level dependencies?

@ChrisRackauckas
Copy link
Member

A search isn't finding any https://github.com/search?q=org%3ASciML+register&type=code&p=1. Odd.

@ArnoStrouwen
Copy link
Member Author

This should be good to go now.

@ChrisRackauckas ChrisRackauckas merged commit 5f8c40a into SciML:master Feb 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants