-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix performance regression #574
Conversation
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
==========================================
+ Coverage 68.87% 68.87% +<.01%
==========================================
Files 81 81
Lines 23997 23998 +1
==========================================
+ Hits 16527 16528 +1
Misses 7470 7470
Continue to review full report at Codecov.
|
By the way, did you test whether the different implementations (that were introduced to circumvent some performance regression due to broadcasting: #107 (comment)) are still required? |
What types of |
At the moment you have to define a scalar norm as well but that will be changed in the next DiffEq release. There's a discussion about this issue in #569. |
Yes, it is still needed. |
Sweet, I find this to be cleaner as well. |
Can we please get a version tag for this fix? Or are there more things currently in the pipeline? |
Release made |
Fixes #571