Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle scalarized array parameters in initialization #3358

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

src/systems/nonlinear/initializesystem.jl Outdated Show resolved Hide resolved
test/initializationsystem.jl Outdated Show resolved Hide resolved
@AayushSabharwal
Copy link
Member Author

A lot of MTK is badly formatted. I'll PR after this to get it all in one go.

@isaacsas
Copy link
Member

A lot of MTK is badly formatted. I'll PR after this to get it all in one go.

Just a suggestion, there was at least one JuliaFormatter release (maybe v2.0?) where people were reporting that it actually reformatted code in a way that introduced bugs into code (domluna/JuliaFormatter.jl#878). So if you do a mass format you might want to carefully review the changes to make sure they are sensible and not breaking code.

@AayushSabharwal
Copy link
Member Author

Thanks! I didn't know about that, but will definitely review the formatted code.

@ChrisRackauckas
Copy link
Member

That was solved months ago though, is there still a relevant case?

@AayushSabharwal
Copy link
Member Author

It seems a little unlikely. Somehow we didn't hit any of it despite actually running formatter regularly around that time frame.

@AayushSabharwal AayushSabharwal merged commit 25c8001 into master Jan 31, 2025
37 of 43 checks passed
@AayushSabharwal AayushSabharwal deleted the as/arr-param-init branch January 31, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants