Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark fixed tests as not broken #249

Merged
merged 1 commit into from
Nov 12, 2022
Merged

Mark fixed tests as not broken #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/interface/ad.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ h(p, t) = p[4]
p = [1.0, 1.5, 1.0, 0.5]
findiff2 = FiniteDiff.finite_difference_gradient(p -> test(vcat(p, p[end])), p)
fordiff2 = ForwardDiff.gradient(p -> test(vcat(p, p[end])), p)
@test_broken maximum(abs.(findiff2 .- fordiff2)) < 2
@test maximum(abs.(findiff2 .- fordiff2)) < 2

# with discontinuity and without delay length estimation
p = [1.5, 1.0, 0.5, 1.0]
Expand Down Expand Up @@ -62,7 +62,7 @@ end
p = [1.0, 1.5, 1.0, 0.5]
findiff2 = FiniteDiff.finite_difference_jacobian(p -> test(vcat(p, p[end])), p)
fordiff2 = ForwardDiff.jacobian(p -> test(vcat(p, p[end])), p)
@test_broken maximum(abs.(findiff2 .- fordiff2)) < 3
@test maximum(abs.(findiff2 .- fordiff2)) < 3

# with discontinuity and without delay length estimation
p = [1.5, 1.0, 0.5, 1.0]
Expand Down Expand Up @@ -96,7 +96,7 @@ end
p = [1.0, 1.5, 1.0, 0.5]
findiff2 = FiniteDiff.finite_difference_hessian(p -> test(vcat(p, p[end])), p)
fordiff2 = ForwardDiff.hessian(p -> test(vcat(p, p[end])), p)
@test_broken maximum(abs.(findiff2 .- fordiff2)) < 25
@test maximum(abs.(findiff2 .- fordiff2)) < 25

# with discontinuity and without delay length estimation
p = [1.5, 1.0, 0.5, 1.0]
Expand Down