Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup tests add script to clone the physiome #24

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Conversation

anandijain
Copy link
Contributor

remove plots and DE->OrdinaryDE
fix release version so register() will work

remove plots and DE->OrdinaryDE
fix tag version
added script to clone the physiome
@anandijain
Copy link
Contributor Author

i'm not super happy about having JSON3 in here, but I still think it'd be better to have some ability to test on the entire model repository.

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #24 (a263a19) into master (10d29f5) will decrease coverage by 2.34%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   54.49%   52.15%   -2.35%     
==========================================
  Files           2        3       +1     
  Lines         178      186       +8     
==========================================
  Hits           97       97              
- Misses         81       89       +8     
Impacted Files Coverage Δ
src/utils.jl 0.00% <0.00%> (ø)
src/CellMLToolkit.jl 70.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10d29f5...a263a19. Read the comment docs.

@shahriariravanian
Copy link
Collaborator

Agree with the changes!

@anandijain anandijain deleted the aj/wip branch March 23, 2021 03:04
@anandijain anandijain restored the aj/wip branch March 23, 2021 03:05
@anandijain
Copy link
Contributor Author

wait did you mean to merge?

@shahriariravanian shahriariravanian merged commit d281318 into master Mar 23, 2021
@anandijain anandijain deleted the aj/wip branch March 23, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants