-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README updated #111
README updated #111
Conversation
README updated to apply new changes to the api.
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 83.80% 0.00% -83.81%
==========================================
Files 6 6
Lines 321 323 +2
==========================================
- Hits 269 0 -269
- Misses 52 323 +271 see 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
README is updated to reflect changes in the OrdinaryDiffEq interface.
@@ -83,8 +83,8 @@ In addition to the model equations, the initial conditions and parameters are al | |||
```Julia | |||
using DifferentialEquations, Plots | |||
|
|||
sol = solve(prob) | |||
plot(sol, vars=(1,3)) | |||
sol = solve(prob, RK4()) # fourth-order Runge-Kutta method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No tutorials should use RK4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted something generic. The default algorithm choice needs DifferentialEquations.jl and is unavailable in OrdinaryDiffEq. Should we change it to DifferentialEquations.jl or use a different solver? It is for the Lorenz equation that can probably be solved with anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using DifferentialEquations.jl is generally a good idea for tutorials as we want people using the default algorithm for most things because they tend to not make the right choices.
No description provided.