Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README updated #111

Merged
merged 4 commits into from
Apr 1, 2023
Merged

README updated #111

merged 4 commits into from
Apr 1, 2023

Conversation

shahriariravanian
Copy link
Collaborator

No description provided.

README updated to apply new changes to the api.
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #111 (d210045) into master (940550b) will decrease coverage by 83.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #111       +/-   ##
==========================================
- Coverage   83.80%   0.00%   -83.81%     
==========================================
  Files           6       6               
  Lines         321     323        +2     
==========================================
- Hits          269       0      -269     
- Misses         52     323      +271     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

README is updated to reflect changes in the OrdinaryDiffEq interface.
@shahriariravanian shahriariravanian merged commit 253ed7e into SciML:master Apr 1, 2023
@@ -83,8 +83,8 @@ In addition to the model equations, the initial conditions and parameters are al
```Julia
using DifferentialEquations, Plots

sol = solve(prob)
plot(sol, vars=(1,3))
sol = solve(prob, RK4()) # fourth-order Runge-Kutta method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tutorials should use RK4

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted something generic. The default algorithm choice needs DifferentialEquations.jl and is unavailable in OrdinaryDiffEq. Should we change it to DifferentialEquations.jl or use a different solver? It is for the Lorenz equation that can probably be solved with anything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using DifferentialEquations.jl is generally a good idea for tutorials as we want people using the default algorithm for most things because they tend to not make the right choices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants