Set known defaults for a CellModels ODESystem
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CellML files contain `initial_value` fields specifying initial values for parameters and states in the system. Retrieving these for the `ODESystem` was already possible, but had to be done separately or as part of the `ODEProblem` constructor defined for `CellModel`s. Defaults are only set for simplified `ODESystem`s. Unsimplified `ODESystem`s may contain parameters and states for which no defaults are available resulting in errors trying to construct the `ODESystem`. These errors will still occur when using the result of calling `process_components` with `simplify = false`, but as noted in the code that should only be done for debugging purposes and this functionality is not exposed at the higher API levels. Fixes SciML#56.
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 83.66% 83.70% +0.04%
==========================================
Files 6 6
Lines 355 356 +1
==========================================
+ Hits 297 298 +1
Misses 58 58
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
awesome, thanks joris |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CellML files contain
initial_valuefields specifying initial values for parameters and states in the system. Retrieving these for theODESystemwas already possible, but had to be done separately or as part of theODEProblemconstructor defined forCellModels. This change makes sure they're added asdefaultsof theODESysteminstead simplifying code that's consuming theseODESystems.Defaults are only set for simplified
ODESystems. UnsimplifiedODESystems may contain parameters and states for which no defaults are available resulting in errors trying to construct theODESystem. These errors will still occur when using the result of callingprocess_componentswithsimplify = false, but as noted in the code that should only be done for debugging purposes and this functionality is not exposed at the higher API levels.Fixes #56.