Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing issues in tests #242

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix typing issues in tests #242

merged 2 commits into from
Dec 17, 2024

Conversation

jl-wynen
Copy link
Collaborator

Necessary to change to --import-mode=importlib for pytest.

@jl-wynen jl-wynen enabled auto-merge October 30, 2024 08:21
@nvaytet nvaytet self-assigned this Nov 1, 2024
nvaytet
nvaytet approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@nvaytet nvaytet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed over the changes, not super thoroughly, but looks fine.

@jl-wynen
Copy link
Collaborator Author

jl-wynen commented Nov 1, 2024

Thanks!
The builds will be broken until #243 is merged.

@jl-wynen jl-wynen merged commit 71d06d2 into main Dec 17, 2024
12 checks passed
@jl-wynen jl-wynen deleted the type-check-tests branch December 17, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvaytet nvaytet nvaytet approved these changes

Assignees

@nvaytet nvaytet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jl-wynen @nvaytet