Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates/fixes in the UI #37

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Small updates/fixes in the UI #37

merged 5 commits into from
Dec 7, 2023

Conversation

despadam
Copy link
Member

@despadam despadam commented Dec 6, 2023

Contains:

  • mainly css changes
  • fixing a couple of typos
  • a small Javascript function that highlights each nav menu tab when the user clicks on it (current status is that only 'Home' tab is highlighted always)

@despadam despadam requested a review from nitrosx December 6, 2023 08:37
@despadam despadam self-assigned this Dec 6, 2023
@nitrosx
Copy link
Member

nitrosx commented Dec 6, 2023

@despadam thank you so much for the PR.
I was wondering if the layout of the team leaders is intentional or it should be as the collaborators one
image

<div class="row">
{% for leader in site.team.leaders %}
<div class="leader col-lg-4 col-sm-6 card">
<div class="leader team-col card">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct?
Please see my comment on the PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitrosx "team-col" was a costum css class but I removed it and aligned the team div in center instead. It should now look like this:

Capture

@despadam
Copy link
Member Author

despadam commented Dec 7, 2023

Also, all links are now updated: the blue color was replaced, plus all links will now open in a new tab when you click on them

@nitrosx nitrosx merged commit a57e5d4 into master Dec 7, 2023
@nitrosx nitrosx deleted the ui-updates branch December 7, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants