Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fe and landingpage entrypoints to common #326

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Move fe and landingpage entrypoints to common #326

merged 2 commits into from
Oct 15, 2024

Conversation

minottic
Copy link
Contributor

@minottic minottic commented Oct 2, 2024

Reduces code duplication

@minottic minottic requested a review from a team October 2, 2024 13:15
@minottic minottic force-pushed the common_entrypoints branch from f2c5970 to 11701a9 Compare October 2, 2024 13:21
@minottic minottic force-pushed the common_entrypoints branch from f9ddad5 to e720343 Compare October 2, 2024 13:33
LAShemilt
LAShemilt approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@LAShemilt LAShemilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks good

@minottic minottic merged commit dc327d5 into main Oct 15, 2024
9 checks passed
@minottic minottic deleted the common_entrypoints branch October 15, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LAShemilt LAShemilt LAShemilt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minottic @LAShemilt