RFC: Configurable access groups #726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpedersen2
force-pushed
the
configurable-access-groups
branch
from
4116a04 to
4039b5c
Compare
bpedersen2
commented
Nov 17, 2023
As not all config settings can be made as environment variables, provide a override mechanism to allow (build-time) configuration adjustments. An example for the graphql access groups provider will be in the next commit. Change-Id: I8dc82ca4f0ac0a1b60fa47eadb147c228a77b841
bpedersen2
force-pushed
the
configurable-access-groups
branch
3 times, most recently
from
040069e to
0f44aca
Compare
Instead of requiring an explict service provider for each facility, use extended configurations. Basic enabling/disabling is implemented in the standard config via environment vars, GraphQL needs extendend configuration via localconfiguration. Change-Id: I2ed630bac8f1f66d4f754e5b95d6b232ec63cf3d
Change-Id: I832b6d9e2680aa8423441924de59c4157b50c8e6
|
Needs local testing at ESS ( as I don't have a graphql endpoint available). Set |
bpedersen2
force-pushed
the
configurable-access-groups
branch
from
0f44aca to
0ff8636
Compare
nitrosx
reviewed
Nov 28, 2023
|
@bpedersen2 can you let me know how I can test this feature before I merge it? Thanks |
5 tasks
|
It has been merged in PR #1041. |
|
Closing as it is now part of #1041 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce easier overridabel compile time configuration and use it for a configurable accessgroups service.
Motivation
Configuring the access groups service needed a custom service provider factory. This needed to get copied during the build, making it hard to validate for all facilities.
This change introduces a new override config file, that can be used for injecting advanced configuration objects that are not environment vars( but as this is merged, allows to keep most defaults easily).
Tests included/Docs Updated?