Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate eslint/prettier step #723

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

bpedersen2
Copy link
Contributor

and remove posttest in package json.

That way lint errors are much more visible in the test stages output.

@bpedersen2
Copy link
Contributor Author

needs #722 to be merged first

@bpedersen2 bpedersen2 added the testing Anything relating with tests and testing label Sep 8, 2023
@bpedersen2 bpedersen2 added the github_actions Pull requests that update GitHub Actions code label Sep 11, 2023
@bpedersen2 bpedersen2 force-pushed the github-lint branch 6 times, most recently from 9c59207 to 94a0ca9 Compare September 15, 2023 12:18
and remove posttest in package json.

That way lint errors are much more visible in the test stages output.

Change-Id: Icd0383cecd43277805fa9eea4ce5d221dda11b72
Change-Id: Iedba153243f0613361e761067b24a28d89f0536e
Fix rules flagged by `npx eslint-config-prettier `

See https://github.com/prettier/eslint-config-prettier#what-and-why

Change-Id: I3441f316e92358f7f9c1ee0bd8eb0956f608d3a3
@nitrosx nitrosx merged commit e390672 into SciCatProject:master Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code testing Anything relating with tests and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants