-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tests for origDatablocks #640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in general. The only thing is that this PR doesn't add only the tests for origDatablocks as it is saying in the title but also fixes some bugs I guess. Another thing is with the numbering of the tests. Not really sure if we need that or not.
Originally, this PR was meant to add only the tests, than I found issues with some of the endpoint (related to the tests that I added), so I addressed them here. |
Description
Added explicit testing for endpoint origdatablocks
Motivation
In the latest code review following issues 638, we realized that there was not any explicit testing for the origdatablocks endpoint.
Changes:
Tests included/Docs Updated?