fix: policies page pagination not working #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junjiequan
changed the title
martin-trajanovski
approved these changes
May 26, 2023
nitrosx
approved these changes
May 26, 2023
…n-doesn-t-work-pr
nitrosx
deleted the
SWAP-3300-scicat-be-items-per-page-function-doesn-t-work-pr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed page pagination for policies page.
Did not include API test for the fix. As in the DatasetLifecycle already included filter test for policies query and it works fine. Considering we are sending filter values in a mixed way of query & header, I think we should keep the test as it is now.
The testing for filter was passing with pagination bug, because in the test it expects to receive filter from query, but the actual filter was sent through header, whereas query filter by default is set to
{}.Tests included/Docs Updated?