Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: orgDatablock fetch retuns with datasetExist field #507

Merged

Conversation

Junjiequan
Copy link
Member

@Junjiequan Junjiequan commented May 21, 2023

Description

Included a customized pipelineStages to origDatablocks' fullquery service.
So that when we trigger GET /origdatablocks/fullquery/files, the pipeline will add and return with datasetExist field that contains boolean value. This datasetExist value can be used on frontend to highlight origDatablocks with invalid dataset.

Motivation

On Scicat files page, if you click an origDatablock that doesn't have valid dataset PID, it will redirect you to a empty dataset detail page.

Fixes:

  • Items added

Changes:

  • changes made

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?

@Junjiequan Junjiequan changed the title [WIP] feat: orgDatablock fetch retuns with datasetExist field feat: orgDatablock fetch retuns with datasetExist field May 22, 2023
Copy link
Collaborator

@martin-trajanovski martin-trajanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but would be nice to have some tests if they are needed to cover the fixes. Maybe another ticket can be created specifically for this if it's not there already.

@Junjiequan Junjiequan self-assigned this May 22, 2023
@nitrosx nitrosx merged commit edac360 into master May 24, 2023
@nitrosx nitrosx deleted the SWAP-3234-scicat-fe-on-files-page-if-dataset-does-not-exist branch May 24, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants