Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logout success with error message #493

Merged
merged 13 commits into from
May 16, 2023
Merged

fix: logout success with error message #493

merged 13 commits into from
May 16, 2023

Conversation

Junjiequan
Copy link
Member

@Junjiequan Junjiequan commented May 12, 2023 •
edited
Loading

Description

fixed local logout error:

  • 404 err: backend is expecting GET but FE is sending POST
  • 401 err: logout function on BE expects auth token

fixed OIDC logout error:

  • Same errors above.
  • On OIDC logout, fetch dataset thumbnail fail error

Motivation

Logout successfully should not show error message

Fixes

Screenshare.-.2023-05-12.10_45_19.AM.mp4

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?

martin-trajanovski
martin-trajanovski approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@martin-trajanovski martin-trajanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 💯

@Junjiequan Junjiequan added the bug Something isn't working label May 12, 2023
@Junjiequan Junjiequan removed the bug Something isn't working label May 12, 2023
@nitrosx nitrosx merged commit 7129ca7 into master May 16, 2023
@nitrosx nitrosx deleted the SWAP-3240-scicat-be-logout-404-or-401-error branch May 16, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrosx nitrosx nitrosx approved these changes

@martin-trajanovski martin-trajanovski martin-trajanovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Junjiequan @nitrosx @martin-trajanovski