feat: enable dataset access for shared emails #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-trajanovski
changed the title
nitrosx
requested changes
May 10, 2023
src/datasets/datasets.controller.ts
Outdated
Comment on lines
956
to
965
| // NOTE: Not sure if email is the best way to do this but since we don't have userId or something like that email is acceptable. | ||
| const couldUpdateDataset = | ||
| datasetToUpdate?.ownerEmail === loggedInUser.email; | ||
| // $addToSet is necessary to append to the field and not overwrite | ||
| // $each is necessary as data is an array of values | ||
|
|
||
| if (!couldUpdateDataset) { | ||
| throw new ForbiddenException(); | ||
| } | ||
|
|
There was a problem hiding this comment.
In order to allow the update on the dataset, we should use the casl factory.
The rules is the following:
- if the user logged in belongs to the group that owns the dataset, he/she is allowed to update the dataset.
- if the user belongs to any of the admin groups, he/she can update the dataset.
There was a problem hiding this comment.
Ahaaa... I see now but do we have these rules set up already or I need to fix that?
There was a problem hiding this comment.
@nitrosx I fixed it and now it uses casl to decide if user is able to update something or not.
nitrosx
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to make shared datasets available for users. Also prevents all users for being able to update datasets and leave that ability only for owners.
Motivation
Anyone that has access to dataset could update or share it and people in sharedWith field were not able to access the datasets.
Fixes:
Changes:
Tests included/Docs Updated?