Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing leading and trailing spaces from groups in lists #430

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

nitrosx
Copy link
Member

@nitrosx nitrosx commented Apr 4, 2023

Description

This PR removes leading and trailing spaces from the groups listed in ADMIN_GROUPS, DELETE_GROUPS and CREATE_DATASET_GROUP.

Motivation

This PR is motivated from the fact that many administrators would add spaces between commas and group names, so the lists are more understandable. This would result in a group name with a leading and/or trailing space, which caused confusion as the user would not see the difference

Changes:

  • src/config/configuration.ts: added trim function when extracting the groups from lists
  • src/casl/casl-ability.factory.ts

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?

@nitrosx nitrosx merged commit 4f0db96 into master Apr 5, 2023
@nitrosx nitrosx deleted the hot-fix-remove-end-spaces-from-groups branch April 5, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant