fix: admin should have access to all logbooks for proposals #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-trajanovski
approved these changes
Apr 4, 2023
Junjiequan
deleted the
SWAP-3195-scicat-admin-should-have-access-to-all-logbooks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, admin can view logbooks in the proposal only when the proposal Id is included in the access group like other normal user.
Motivation
As an admin I want to be able to access all logbooks in any proposals.
Fixes:
https://jira.esss.lu.se/browse/SWAP-3195
Tests included/Docs Updated?