Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw error instead of returning null with success if register DOI failed and fix the register endpoint bugs #416

Merged
merged 7 commits into from
Apr 4, 2023
Merged

fix: throw error instead of returning null with success if register DOI failed and fix the register endpoint bugs #416

merged 7 commits into from
Apr 4, 2023

Conversation

martin-trajanovski
Copy link
Collaborator

@martin-trajanovski martin-trajanovski commented Apr 3, 2023 •
edited
Loading

Description

  1. Fix register published data endpoint bugs
  2. Throw error if something goes wrong instead of returning null

Motivation

Register published data was not working previously

Fixes:

Changes:

  • changes made

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?

@martin-trajanovski martin-trajanovski changed the title fix: throw error instead of returning null with success if register D… fix: throw error instead of returning null with success if register DOI failed and fix the register endpoint bugs Apr 4, 2023
@martin-trajanovski martin-trajanovski marked this pull request as ready for review April 4, 2023 08:49
@martin-trajanovski martin-trajanovski self-assigned this Apr 4, 2023
@nitrosx nitrosx merged commit 52ec511 into master Apr 4, 2023
@nitrosx nitrosx deleted the SWAP-3178-throw-error-if-register-not-successful branch April 4, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrosx nitrosx nitrosx approved these changes

Assignees

@martin-trajanovski martin-trajanovski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-trajanovski @nitrosx