Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap 3172 - Fix user endpoint authorization #415

Merged
merged 8 commits into from
Apr 3, 2023
Merged

Swap 3172 - Fix user endpoint authorization #415

merged 8 commits into from
Apr 3, 2023

Conversation

nitrosx
Copy link
Member

@nitrosx nitrosx commented Mar 31, 2023

Description

This PR fixes authorization for the users endpoint, including userIdentities. IT also adds API testings.

Motivation

During our e2e demo, we discovered that the FE does not show user current groups as the call to the backend fails with a 403.

Fixes:

  • tests/UserAuthorization.js

Changes:

  • src/config/configuration.ts: added user4
  • src/users/user.controller.ts: fixed all authorization for all the endpoint
  • src/users/user-identities.controller.ts: added authorization for the only endpoint.

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?

@nitrosx nitrosx merged commit 0835f3f into master Apr 3, 2023
@nitrosx nitrosx deleted the swap-3172 branch April 3, 2023 09:36
@jkotan jkotan mentioned this pull request Sep 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-trajanovski martin-trajanovski Awaiting requested review from martin-trajanovski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrosx @martin-trajanovski