Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check permissions on dataset create #392

Merged
merged 4 commits into from
Mar 20, 2023

Conversation

nitrosx
Copy link
Member

@nitrosx nitrosx commented Mar 20, 2023

Description

This PR updated user authorization in casl-factory, added extra authorization check on dataset create.
Now normal user can create dataset only if the dataset belongs to one of the groups they belong to

Motivation

We want to be able normal users to create dataset only if the owner group is one of the groups they belong to.

Changes:

  • updated casl-factory to include create permissions for normal users
  • added function to check permissions on dataset create

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?

@nitrosx nitrosx merged commit eb0eaad into master Mar 20, 2023
@nitrosx nitrosx deleted the swap-3156-verifying-user-permissions-on-creation branch March 20, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant